Skip to content

File-scoped namespaces in files under ComponentModel (Microsoft.ML.Core) #6788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 31, 2023
Merged

File-scoped namespaces in files under ComponentModel (Microsoft.ML.Core) #6788

merged 2 commits into from
Aug 31, 2023

Conversation

Lehonti
Copy link
Contributor

@Lehonti Lehonti commented Aug 10, 2023

No description provided.

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #6788 (b83b18b) into main (39235a7) will increase coverage by 0.01%.
The diff coverage is 71.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6788      +/-   ##
==========================================
+ Coverage   69.03%   69.04%   +0.01%     
==========================================
  Files        1237     1237              
  Lines      252700   252700              
  Branches    26446    26446              
==========================================
+ Hits       174449   174478      +29     
+ Misses      71308    71283      -25     
+ Partials     6943     6939       -4     
Flag Coverage Δ
Debug 69.04% <71.32%> (+0.01%) ⬆️
production 63.62% <71.32%> (+0.01%) ⬆️
test 88.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...oft.ML.Core/ComponentModel/AssemblyLoadingUtils.cs 68.67% <68.96%> (ø)
...crosoft.ML.Core/ComponentModel/ComponentFactory.cs 75.00% <70.00%> (ø)
...crosoft.ML.Core/ComponentModel/ComponentCatalog.cs 70.24% <70.14%> (ø)
...t.ML.Core/ComponentModel/LoadableClassAttribute.cs 80.64% <83.11%> (ø)
...t.ML.Core/ComponentModel/ExtensionBaseAttribute.cs 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 34389b6 into dotnet:main Aug 31, 2023
@Lehonti Lehonti deleted the improvement2 branch August 31, 2023 07:28
@ghost ghost locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants