Skip to content

Updates LightGBM from 2.X.X to 3.X.X #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Conversation

michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Nov 9, 2023

Updates LightGBM from 2.X.X to 3.X.X and all the associated baseline test files.

Also updates the SQL nuget package for its security update.

Copy link
Member

@jeffhandley jeffhandley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to assess the output result differences; is there anything in those changes that give you pause or concern?

@michaelgsharp
Copy link
Member Author

No concern on the output changes. Besides the fact that the training size is so small that anything (sneezes included) can change the output, these results are 100% done by the third party library, so we are ok with all changes that come from their changes.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #6880 (6804745) into main (d2cf997) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6880      +/-   ##
==========================================
- Coverage   68.81%   68.80%   -0.01%     
==========================================
  Files        1240     1240              
  Lines      249392   249392              
  Branches    25493    25493              
==========================================
- Hits       171607   171600       -7     
- Misses      71191    71196       +5     
- Partials     6594     6596       +2     
Flag Coverage Δ
Debug 68.80% <100.00%> (-0.01%) ⬇️
production 63.26% <100.00%> (-0.01%) ⬇️
test 88.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/Microsoft.ML.LightGbm/WrappedLightGbmBooster.cs 90.47% <100.00%> (ø)
.../Microsoft.ML.LightGbm/WrappedLightGbmInterface.cs 87.71% <ø> (ø)
...cenariosWithDirectInstantiation/TensorflowTests.cs 91.71% <100.00%> (ø)
...osoft.ML.Tests/TrainerEstimators/TreeEstimators.cs 97.84% <100.00%> (ø)

... and 3 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit aeb1ab8 into dotnet:main Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@michaelgsharp michaelgsharp deleted the lightgbm branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants