-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Updates LightGBM from 2.X.X to 3.X.X #6880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how to assess the output result differences; is there anything in those changes that give you pause or concern?
cb75e4b
to
b78040c
Compare
No concern on the output changes. Besides the fact that the training size is so small that anything (sneezes included) can change the output, these results are 100% done by the third party library, so we are ok with all changes that come from their changes. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6880 +/- ##
==========================================
- Coverage 68.81% 68.80% -0.01%
==========================================
Files 1240 1240
Lines 249392 249392
Branches 25493 25493
==========================================
- Hits 171607 171600 -7
- Misses 71191 71196 +5
- Partials 6594 6596 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Updates LightGBM from 2.X.X to 3.X.X and all the associated baseline test files.
Also updates the SQL nuget package for its security update.