Skip to content

Rename NameEntity to NamedEntity #6917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Dec 20, 2023

Renaming while obsoleting the public API. We'll backport this to 3.0, then we'll remove the obsolete members from 4.0.

@ghost ghost assigned ericstj Dec 20, 2023
@ericstj ericstj force-pushed the obsoleteNameEntityRecogniton branch from ce8d887 to a18a570 Compare December 20, 2023 19:31
@ericstj ericstj force-pushed the obsoleteNameEntityRecogniton branch from a18a570 to 24053b3 Compare December 20, 2023 19:32
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (efab011) 68.79% compared to head (24053b3) 68.80%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6917   +/-   ##
=======================================
  Coverage   68.79%   68.80%           
=======================================
  Files        1249     1249           
  Lines      249431   249433    +2     
  Branches    25510    25510           
=======================================
+ Hits       171604   171613    +9     
+ Misses      71214    71211    -3     
+ Partials     6613     6609    -4     
Flag Coverage Δ
Debug 68.80% <81.81%> (+<0.01%) ⬆️
production 63.26% <80.00%> (+<0.01%) ⬆️
test 88.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Microsoft.ML.TorchSharp/NasBert/NasBertTrainer.cs 80.12% <100.00%> (ø)
src/Microsoft.ML.TorchSharp/NasBert/NerTrainer.cs 88.23% <100.00%> (ø)
test/Microsoft.ML.Tests/NerTests.cs 100.00% <100.00%> (ø)
src/Microsoft.ML.TorchSharp/TorchSharpCatalog.cs 60.00% <0.00%> (-9.24%) ⬇️

... and 4 files with indirect coverage changes

@ericstj
Copy link
Member Author

ericstj commented Dec 21, 2023

Only failure here is #6921

@ericstj ericstj merged commit a60be5f into dotnet:main Dec 21, 2023
@ericstj
Copy link
Member Author

ericstj commented Jan 8, 2024

/backport to release/3.0

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Started backporting to release/3.0: https://github.com/dotnet/machinelearning/actions/runs/7453292024

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants