Skip to content

Update OnnxRuntime to 1.16.3 #6975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Conversation

michaelgsharp
Copy link
Member

Updates OnnxRuntime to 1.16.3 and fixes the breaking change.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e28578) 68.80% compared to head (859c078) 68.83%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6975      +/-   ##
==========================================
+ Coverage   68.80%   68.83%   +0.02%     
==========================================
  Files        1249     1258       +9     
  Lines      249686   250674     +988     
  Branches    25485    25615     +130     
==========================================
+ Hits       171806   172556     +750     
- Misses      71286    71487     +201     
- Partials     6594     6631      +37     
Flag Coverage Δ
Debug 68.83% <100.00%> (+0.02%) ⬆️
production 63.27% <100.00%> (-0.01%) ⬇️
test 88.56% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/Microsoft.ML.OnnxTransformer/OnnxUtils.cs 84.21% <100.00%> (+0.12%) ⬆️

... and 26 files with indirect coverage changes

@ericstj
Copy link
Member

ericstj commented Feb 13, 2024

/azp run MachineLearning-CI

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ericstj
Copy link
Member

ericstj commented Feb 13, 2024

Seems like the failure is OnnxRuntime related:
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-machinelearning-refs-pull-6975-merge-6fd5fb0c27da42dbaa/Microsoft.ML.AutoML.Tests/1/console.d0e26785.log?helixlogtype=result

    Microsoft.ML.AutoML.Test.AutoFitTests.AutoFitMultiClassification_Image_CV [FAIL]
      System.AggregateException : One or more errors occurred. (The type initializer for 'Microsoft.ML.OnnxRuntime.NativeMethods' threw an exception.)
      ---- System.TypeInitializationException : The type initializer for 'Microsoft.ML.OnnxRuntime.NativeMethods' threw an exception.
      -------- System.NullReferenceException : Object reference not set to an instance of an object.
      Stack Trace:
           at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
           at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
           at System.Threading.Tasks.Task`1.get_Result()
        D:\a\_work\1\s\src\Microsoft.ML.AutoML\AutoMLExperiment\AutoMLExperiment.cs(204,0): at Microsoft.ML.AutoML.AutoMLExperiment.Run()

@michaelgsharp michaelgsharp marked this pull request as ready for review February 21, 2024 10:15
@michaelgsharp michaelgsharp merged commit 4d4f7dc into dotnet:main Feb 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
@michaelgsharp michaelgsharp deleted the onnx-1.16 branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants