Skip to content

Temp fix for the race condition during the tests. #7021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

michaelgsharp
Copy link
Member

Temporarily fixes the race condition that seems to be happening during the tests by making the offending tests run sequentially.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64523e8) 68.81% compared to head (0c790ee) 68.81%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7021      +/-   ##
==========================================
- Coverage   68.81%   68.81%   -0.01%     
==========================================
  Files        1258     1258              
  Lines      250477   250672     +195     
  Branches    25576    25614      +38     
==========================================
+ Hits       172377   172488     +111     
- Misses      71473    71551      +78     
- Partials     6627     6633       +6     
Flag Coverage Δ
Debug 68.81% <ø> (-0.01%) ⬇️
production 63.27% <ø> (-0.02%) ⬇️
test 88.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 94.41% <ø> (ø)
...osoft.ML.Tests/Transformers/WordEmbeddingsTests.cs 100.00% <ø> (ø)

... and 23 files with indirect coverage changes

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please open issue to track removing the serialization later? Thanls!

@michaelgsharp michaelgsharp merged commit 0d2fd60 into dotnet:main Feb 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
@michaelgsharp michaelgsharp deleted the temp-race-fix branch November 18, 2024 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants