-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add Span support in tokenizer's Model abstraction #7035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Span support in tokenizer's Model abstraction #7035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7035 +/- ##
==========================================
+ Coverage 68.79% 68.80% +0.01%
==========================================
Files 1254 1255 +1
Lines 250204 250248 +44
Branches 25529 25533 +4
==========================================
+ Hits 172127 172190 +63
+ Misses 71467 71449 -18
+ Partials 6610 6609 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This change is adding Span support to the Tokenizer's Model abstraction. This will help in performance and not restrict us in the future to use spans without to worry about more memory allocations.