Skip to content

Update DependencyModel #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Dec 16, 2024

This was transitively bringing in an older System.Text.Json in the test projects

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.87%. Comparing base (5090327) to head (b32ce00).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #7338     +/-   ##
=========================================
  Coverage   68.87%   68.87%             
=========================================
  Files        1470     1473      +3     
  Lines      274005   270771   -3234     
  Branches    28403    27884    -519     
=========================================
- Hits       188717   186498   -2219     
+ Misses      77970    76998    -972     
+ Partials     7318     7275     -43     
Flag Coverage Δ
Debug 68.87% <ø> (+<0.01%) ⬆️
production 63.18% <ø> (-0.10%) ⬇️
test 89.38% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 65 files with indirect coverage changes

@ericstj ericstj merged commit 23052ec into dotnet:main Dec 16, 2024
25 checks passed
@ericstj
Copy link
Member Author

ericstj commented Dec 16, 2024

/backport to release/4.0

Copy link
Contributor

Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/12362190200

Copy link
Contributor

@ericstj backporting to release/4.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Update DependencyModel
Using index info to reconstruct a base tree...
M	eng/Versions.props
Falling back to patching base and 3-way merge...
Auto-merging eng/Versions.props
CONFLICT (content): Merge conflict in eng/Versions.props
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update DependencyModel
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants