-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update Microsoft.Extensions.AI to 9.3.0-preview.1.25114.11 #7388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Microsoft.Extensions.AI dependency to version 9.3.0-preview.1.25114.11 and, as part of that update, renames several ChatClient methods and types to better reflect the new ChatResponse-based interface.
- Renamed methods from CompleteAsync/CompleteStreamingAsync to GetResponseAsync/GetStreamingResponseAsync.
- Changed return types from ChatCompletion/StreamingChatCompletionUpdate to ChatResponse/ChatResponseUpdate.
- Refactored metadata handling by replacing the Metadata property with a private _metadata field.
- Updated sample files to use the new method names.
Changes
File | Description |
---|---|
src/Microsoft.ML.GenAI.Core/CausalLMPipelineChatClient.cs | Updated method names and return types, and refactored metadata handling. |
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs | Renamed methods and updated base calls to reflect new ChatResponse types. |
docs/samples/Microsoft.ML.GenAI.Samples/MEAI/Phi3.cs | Updated sample to use the new GetStreamingResponseAsync method. |
src/Microsoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs | Renamed methods and updated base calls to reflect new ChatResponse types. |
docs/samples/Microsoft.ML.GenAI.Samples/MEAI/Llama3_1.cs | Updated sample to use the new GetStreamingResponseAsync method. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/Microsoft.ML.GenAI.Phi/Phi3/Phi3CausalLMChatClient.cs:57
- The initializer '[]' is not valid C# syntax for initializing a list. Consider using 'new List()' if StopSequences requires a mutable list.
options.StopSequences ??= [];
src/Microsoft.ML.GenAI.LLaMA/Llama3CausalLMChatClient.cs:52
- The initializer '[]' is not valid C# syntax for initializing a list. Consider using 'new List()' if StopSequences requires a mutable list.
options.StopSequences ??= [];
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7388 +/- ##
==========================================
- Coverage 68.88% 68.88% -0.01%
==========================================
Files 1473 1473
Lines 270814 270815 +1
Branches 27884 27883 -1
==========================================
- Hits 186553 186548 -5
- Misses 76985 76991 +6
Partials 7276 7276
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/ba-g test failure is #7393 |
No description provided.