-
Notifications
You must be signed in to change notification settings - Fork 328
Support UDF that returns RowType #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…liu/spark into elva/udfReturnRowType
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.Worker/Command/SqlCommandExecutor.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.Worker/Command/SqlCommandExecutor.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.Worker/Command/SqlCommandExecutor.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to git add /path/to/GenericRowPickler.cs
. The file wasn't added with your latest commits.
…liu/spark into elva/udfReturnRowType
src/csharp/Microsoft.Spark.E2ETest/UdfTests/UdfComplexTypesTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @elvaliuliuliu (and @suhsteve for review)!
This PR exposes new API to support udf that returns RowType. It will fix #117.
Please see below as an example:
Udf
that returnsGenericRow
looks like the following: