Skip to content

fix(Table): stuck search form-control when press keyup/keydown when IsExcel mode #5826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Apr 16, 2025

Link issues

fixes #5822

Summary By Copilot

This pull request includes improvements to the setExcelKeyboardListener function in the Table.razor.js file. The changes focus on enhancing the focus and selection handling for table cells and improving the navigation logic for keyboard arrow key events.

Enhancements to focus and selection handling:

  • Added checks to ensure the focus and select methods are only called if they exist on the target element. (src/BootstrapBlazor/Components/Table/Table.razor.js)

Improvements to keyboard navigation logic:

  • Modified the logic for the UP and DOWN arrow keys to handle cases where the next or previous row might be null, ensuring that the navigation continues until a valid row is found. (src/BootstrapBlazor/Components/Table/Table.razor.js)

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Improve keyboard navigation and focus handling for table cells in Excel mode

Bug Fixes:

  • Fix stuck search form-control when pressing up/down keys in Excel mode by adding robust navigation between rows and cells

Enhancements:

  • Enhance keyboard navigation logic to handle cases with null rows
  • Add defensive checks before calling focus and select methods on target elements

@bb-auto bb-auto bot added the bug Something isn't working label Apr 16, 2025
Copy link
Contributor

sourcery-ai bot commented Apr 16, 2025

Reviewer's Guide by Sourcery

This pull request addresses an issue where the search form control in the Table component would get stuck when pressing the keyup/keydown keys in Excel mode. The changes primarily involve modifications to the setExcelKeyboardListener function in Table.razor.js to improve focus and selection handling, as well as enhance keyboard navigation logic.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Improved focus and selection handling for table cells.
  • Added checks to ensure the focus and select methods are only called if they exist on the target element.
src/BootstrapBlazor/Components/Table/Table.razor.js
Enhanced keyboard navigation logic for up and down arrow keys.
  • Modified the logic for the UP and DOWN arrow keys to handle cases where the next or previous row might be null, ensuring that the navigation continues until a valid row is found.
src/BootstrapBlazor/Components/Table/Table.razor.js
Updated the selector for the target element in the activeCell function.
  • The selector was updated from input.form-control:not([readonly]) to .form-control:not([readonly]).
src/BootstrapBlazor/Components/Table/Table.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#5822 Fix the issue where pressing the down arrow key in a textarea within a table in Excel mode causes the page to freeze.
#5822 Improve focus and selection handling for table cells in Excel mode.
#5822 Improve keyboard navigation logic for up and down arrow keys in table excel mode.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the v9.5.0 milestone Apr 16, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We encountered an error and are unable to review this PR. We have been notified and are working to fix it.

You can try again by commenting this pull request with @sourcery-ai review, or contact us for help.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (698666c) to head (922bec4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #5826   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          660       660           
  Lines        30136     30136           
  Branches      4253      4253           
=========================================
  Hits         30136     30136           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 46b08a3 into main Apr 16, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch April 16, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Table): stuck search form-control when press keyup/keydown when IsExcel mode
1 participant