-
-
Notifications
You must be signed in to change notification settings - Fork 345
fix(Table): stuck search form-control when press keyup/keydown when IsExcel mode #5826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request addresses an issue where the search form control in the Table component would get stuck when pressing the keyup/keydown keys in Excel mode. The changes primarily involve modifications to the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We encountered an error and are unable to review this PR. We have been notified and are working to fix it.
You can try again by commenting this pull request with @sourcery-ai review
, or contact us for help.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5826 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30136 30136
Branches 4253 4253
=========================================
Hits 30136 30136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #5822
Summary By Copilot
This pull request includes improvements to the
setExcelKeyboardListener
function in theTable.razor.js
file. The changes focus on enhancing the focus and selection handling for table cells and improving the navigation logic for keyboard arrow key events.Enhancements to focus and selection handling:
focus
andselect
methods are only called if they exist on the target element. (src/BootstrapBlazor/Components/Table/Table.razor.js
)Improvements to keyboard navigation logic:
null
, ensuring that the navigation continues until a valid row is found. (src/BootstrapBlazor/Components/Table/Table.razor.js
)Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Improve keyboard navigation and focus handling for table cells in Excel mode
Bug Fixes:
Enhancements: