-
-
Notifications
You must be signed in to change notification settings - Fork 346
bug(NavigateToExtensions): not work NavigateTo extension method #6026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: adminyr <[email protected]>
🧙 Sourcery has finished reviewing your pull request! Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6026 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 701 701
Lines 30888 30888
Branches 4373 4373
=========================================
Hits 30888 30888 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6025
Summary By Copilot
This pull request includes a version update and a minor improvement to the
Menu
component logic in theBootstrapBlazor
project.Version update:
src/BootstrapBlazor/BootstrapBlazor.csproj
: Updated the project version from9.6.2-beta06
to9.6.2
, indicating a transition from beta to a stable release.Logic improvement in
Menu
component:src/BootstrapBlazor/Components/Menu/Menu.razor.cs
: Modified theOnParametersSet
method to use the null-coalescing assignment operator (??=
) for settingOptions.Text
, ensuring it only updates ifOptions.Text
is currently null.Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Fix the overwriting of navigation text in the Menu component by using a null-coalescing assignment and bump the project from beta to a stable release.
Bug Fixes:
Build: