chore: import t-digest-c lib #5102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
May 12, 2025
| * the include of your alternate allocator if needed (not needed in order | ||
| * to use the default libc allocator). */ | ||
|
|
||
| #ifndef TD_ALLOC_H |
There was a problem hiding this comment.
TODO I should enable mimalloc
There was a problem hiding this comment.
Are you going to do this in this PR?
kostasrim
commented
May 12, 2025
| * The implementation is a direct descendent of MergingDigest | ||
| * https://github.com/tdunning/t-digest/ | ||
| * | ||
| * Copyright (c) 2021 Redis, All rights reserved. |
There was a problem hiding this comment.
I think it should be ok to leave this here
There was a problem hiding this comment.
it's appache 2.0 so we should be ok using it
There was a problem hiding this comment.
Yes, please keep the headers, also please add the license file LICENSE.md and name it t-digest.LICENSE.md
BagritsevichStepan
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.