chore: add tests #5128
Merged
chore: add tests #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
May 14, 2025
| @@ -457,8 +462,15 @@ void TDigestFamily::Quantile(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| }; | |||
|
|
|||
| auto res = cmd_cntx.tx->ScheduleSingleHopT(cb); | |||
| // SendError covers ok | |||
| return cmd_cntx.rb->SendError(res.status()); | |||
| if (!res) { | |||
There was a problem hiding this comment.
I will extract those in a function at some point 🤣
There was a problem hiding this comment.
Ah, okay. So my previous comment can be ignored.
kostasrim
commented
May 14, 2025
| @@ -20,7 +20,14 @@ class TDigestFamilyTest : public BaseFamilyTest { | |||
| protected: | |||
| }; | |||
|
|
|||
| TEST_F(TDigestFamilyTest, TDigestBasic) { | |||
| TEST_F(TDigestFamilyTest, Basic) { | |||
There was a problem hiding this comment.
We now have tests for all TDIGEST commands :)
|
only serialization is left and this is feature complete. |
| // SendError covers ok | ||
| return cmd_cntx.rb->SendError(res.status()); | ||
| if (!res) { | ||
| return cmd_cntx.rb->SendError(res.status()); |
There was a problem hiding this comment.
Please move it below auto* rb = static_cast<facade::RedisReplyBuilder*>(cmd_cntx.rb);
| @@ -457,8 +462,15 @@ void TDigestFamily::Quantile(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| }; | |||
|
|
|||
| auto res = cmd_cntx.tx->ScheduleSingleHopT(cb); | |||
| // SendError covers ok | |||
| return cmd_cntx.rb->SendError(res.status()); | |||
| if (!res) { | |||
There was a problem hiding this comment.
Ah, okay. So my previous comment can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of bugs around command replies for tdigest functions and adds tests.