fix(json_family): Fix bugs where JSON commands were modifying values of other data types #5266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jun 10, 2025
romange
previously approved these changes
Jun 10, 2025
BagritsevichStepan
force-pushed
the
json/fix-non-type-iterators
branch
from
9f44632 to
0b4b285
Compare
…of other data types fixes dragonflydb#5265 Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
json/fix-non-type-iterators
branch
from
0b4b285 to
f8cde45
Compare
|
Actually, we do not need change AddOrFind here, create a separate ticket for this: #5271 |
romange
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5265
In this PR, I addedreq_obj_typeto theAddOrFindmethod. I see that this method is also used in other data types, which could lead to bugs. Once this PR is approved, I will review other commands and possibly remove the version ofAddOrFindthat doesn't needreq_obj_type.This PR fixes several bugs that are well described in the issue above::
JSON.SETcommandJSON.DELcommandJSON.GETcommand