chore: replace dcheck with check for partial sync #5277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
src/server/journal/journal_slice.cc
Outdated
| @@ -111,11 +111,11 @@ void JournalSlice::CallOnChange(JournalItem* item) { | |||
| // We preserve order here. After ConsumeJournalChange there can reordering | |||
| if (ring_buffer_.size() == ring_buffer_.capacity()) { | |||
| const size_t bytes_removed = ring_buffer_.front().data.size() + sizeof(*item); | |||
| DCHECK_GE(ring_buffer_bytes, bytes_removed); | |||
| CHECK_EQ(ring_buffer_bytes, bytes_removed); | |||
There was a problem hiding this comment.
If we are about to revert this, I suggest adding a todo here or creating an issue.
There was a problem hiding this comment.
no need, I will revert this as part of the PR that fixes #5275
|
but why merge this? you can run regression tests on this branch and see if this check fails when the test is failing |
yeah I wanted this to run on the night just in case it would not fail if I added a loop -- anyway I can prioritize this now |
This was referenced Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced the DCHECK with CHECK because #5275
I will revert this commit once we debug this.