fix: client kill preempts in atomic section on shutdown #5283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
kostasrim
commented
Jun 12, 2025
| facade::Connection::WeakRef ref = std::move(kill_list.front()); | ||
| kill_list.pop_front(); | ||
| facade::Connection* conn = ref.Get(); | ||
| // TODO think how to handle migration for eval. See RequestAsyncMigration |
There was a problem hiding this comment.
Need to think what we can do here
kostasrim
commented
Jun 12, 2025
| @@ -535,14 +535,39 @@ void ClientKill(CmdArgList args, absl::Span<facade::Listener*> listeners, SinkRe | |||
|
|
|||
| const bool is_admin_request = cntx->conn()->IsPrivileged(); | |||
|
|
|||
| std::vector<util::fb2::Fiber> fibers(pp->size() * listeners.size()); | |||
There was a problem hiding this comment.
IMO we could also have a single fiber per shard which sleeps and wake up when we push work to its queue. IMO I have no preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that
TlsSocket::Shutdownis preemptive because it flushes its buffer on the socket. However this violated the FiberAtomicGuard when traversing the connection list on each shard. To fix this, we move the shutdown call to another fiber.