chore: Improve scope/aggregator usage in replies #5286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romange
reviewed
Jun 12, 2025
src/server/bloom_family.cc
Outdated
| @@ -179,10 +179,10 @@ void BloomFamily::MExists(CmdArgList args, const CommandContext& cmd_cntx) { | |||
| return OpExists(t->GetOpArgs(shard), key, args); | |||
| }; | |||
|
|
|||
| OpResult res = cmd_cntx.tx->ScheduleSingleHopT(std::move(cb)); | |||
| auto res = cmd_cntx.tx->ScheduleSingleHopT(std::move(cb)); | |||
There was a problem hiding this comment.
please do not convert to auto - when it hurts readability
romange
reviewed
Jun 15, 2025
src/facade/reply_builder.h
Outdated
| void SendSimpleStrArr(const facade::ArgRange& strs); | ||
| void SendBulkStrArr(const facade::ArgRange& strs, CollectionType ct = ARRAY); | ||
| void SendLongArr(absl::Span<const long> longs); |
There was a problem hiding this comment.
instead of changing result types - let's make it more flexible.
template<typename I>` void SendLongArr(absl::Span<const I> longs) {
}
romange
reviewed
Jun 15, 2025
src/server/list_family.cc
Outdated
| @@ -576,8 +576,8 @@ OpResult<string> OpIndex(const OpArgs& op_args, std::string_view key, long index | |||
| return str; | |||
| } | |||
|
|
|||
| OpResult<vector<uint32_t>> OpPos(const OpArgs& op_args, string_view key, string_view element, | |||
| int rank, uint32_t count, uint32_t max_len) { | |||
| OpResult<vector<long>> OpPos(const OpArgs& op_args, string_view key, string_view element, int rank, | |||
|
Cluster family test failed spuriously in the previour CI run 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.