chore(db_slice): Add object type to AddOrFind #5305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BagritsevichStepan
force-pushed
the
db_slice/fix-add-or-find-method
branch
2 times, most recently
from
0d48c8b to
87cea6c
Compare
fixes dragonflydb#5271 Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
db_slice/fix-add-or-find-method
branch
from
87cea6c to
950ce19
Compare
BorysTheDev
reviewed
Jun 16, 2025
|
LGTM, but let's someone else review it too |
romange
reviewed
Jun 16, 2025
Signed-off-by: Stepan Bagritsevich <[email protected]>
BagritsevichStepan
force-pushed
the
db_slice/fix-add-or-find-method
branch
from
d8fba3e to
5c70b96
Compare
romange
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5271
This PR introduces an
unsigned req_obj_typeparameter to theAddOrFindmethod (with the main changes located in the db_slice files). It also verifies that all usages of AddOrFind across the codebase behave as expected.