Rename steamrommanager.sh to steam-rom-manager.sh #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid being misidentified as steam by Steam Rom Manager.
jcchikikomori
approved these changes
Oct 24, 2025
Contributor
|
just my 2 cents, but why not adding a simple variable(like SRM_script or similar) for that name since it's used in quite some places? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current name of the script results in Steam Rom Manager misidentifying the launcher as steam, causing some issues with categorization in Steam Rom Manager, see #1536
Steam Rom Manager uses an exclusion list to avoid this issue with other similar tools: https://github.com/SteamGridDB/steam-rom-manager/blob/d0b1f98c4622ffbdb3f784240599a1a032262ae7/src/lib/category-manager.ts#L68
steamrommanager is not on their exclusion list, but steam-rom-manager is