Skip to content

Conversation

@pjbull
Copy link
Member

@pjbull pjbull commented Dec 29, 2022

Updates a number of issues with S3Client internals, primarily the ability to pass extra_args that may be necessary to a user. This is primarily to address #254 and #180, which require passing extras around at the client level.

The current implementation assumes that all of the upload/download/listing operations will always use the same extras at the level of a client. This is reasonable for most of the extra args except some of the upload ones (Metadata, ContentType, etc.). For the ContentType and ContentEncoding, we already provide a separate means of setting these per-file.

Additionally, we add documentation for RequestPayer explicitly and then ExtraArgs generally.

Bonus:

Closes #48
Closes #254
Closes #180
Closes #271
Closes #212

@pjbull pjbull requested a review from jayqi December 29, 2022 01:19
@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2022

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #307 (98dde40) into master (927c038) will decrease coverage by 0.2%.
The diff coverage is 89.1%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #307     +/-   ##
========================================
- Coverage    94.5%   94.2%   -0.3%     
========================================
  Files          21      21             
  Lines        1384    1399     +15     
========================================
+ Hits         1309    1319     +10     
- Misses         75      80      +5     
Impacted Files Coverage Δ
cloudpathlib/gs/gsclient.py 94.3% <80.0%> (-0.7%) ⬇️
cloudpathlib/azure/azblobclient.py 93.8% <83.3%> (-0.7%) ⬇️
cloudpathlib/s3/s3client.py 93.1% <91.1%> (-2.1%) ⬇️
cloudpathlib/local/implementations/azure.py 97.6% <100.0%> (ø)

@pjbull pjbull merged commit 0b6a2a3 into master Dec 30, 2022
@pjbull
Copy link
Member Author

pjbull commented Dec 30, 2022

Thanks @jayqi !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment