Skip to content

MF-5246 Prefix variables with "this." in hashcode function to prevent name clashes with "hash" #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
base64DataValue
this._tag,
this.base64DataValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public PhotoSourceArg getPhoto() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
photo
this.photo
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public String getProfilePhotoUrl() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
profilePhotoUrl
this.profilePhotoUrl
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,8 @@ public boolean isComplete() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
asyncJobIdValue
this._tag,
this.asyncJobIdValue
});
hash = (31 * super.hashCode()) + hash;
return hash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,8 +163,8 @@ public String getAsyncJobIdValue() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
asyncJobIdValue
this._tag,
this.asyncJobIdValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public String getAsyncJobId() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
asyncJobId
this.asyncJobId
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -254,9 +254,9 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
invalidAccountTypeValue,
paperAccessDeniedValue
this._tag,
this.invalidAccountTypeValue,
this.paperAccessDeniedValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
missingScopeValue
this._tag,
this.missingScopeValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ public long getRetryAfter() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
reason,
retryAfter
this.reason,
this.retryAfter
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ public String getOauth1TokenSecret() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
oauth1Token,
oauth1TokenSecret
this.oauth1Token,
this.oauth1TokenSecret
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public String getOauth2Token() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
oauth2Token
this.oauth2Token
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public String getRequiredScope() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
requiredScope
this.requiredScope
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public String getQuery() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
query
this.query
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public String getResult() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
result
this.result
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -289,9 +289,9 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
rootValue,
namespaceIdValue
this._tag,
this.rootValue,
this.namespaceIdValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
invalidRootValue
this._tag,
this.invalidRootValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ public String getHomeNamespaceId() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
rootNamespaceId,
homeNamespaceId
this.rootNamespaceId,
this.homeNamespaceId
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public String getHomePath() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
homePath
this.homePath
});
hash = (31 * super.hashCode()) + hash;
return hash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public List<String> getEmailAddresses() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
emailAddresses
this.emailAddresses
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
contactsNotFoundValue
this._tag,
this.contactsNotFoundValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ public List<PropertyGroup> getPropertyGroups() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
path,
propertyGroups
this.path,
this.propertyGroups
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,9 @@ public boolean isPropertyGroupAlreadyExists() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
templateNotFoundValue,
pathValue
this._tag,
this.templateNotFoundValue,
this.pathValue
});
hash = (31 * super.hashCode()) + hash;
return hash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public String getTemplateId() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
templateId
this.templateId
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public String getTemplateId() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
templateId
this.templateId
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,9 @@ public boolean isDuplicatePropertyGroups() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
templateNotFoundValue,
pathValue
this._tag,
this.templateNotFoundValue,
this.pathValue
});
hash = (31 * super.hashCode()) + hash;
return hash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ public List<String> getTemplateIds() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
templateIds
this.templateIds
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
malformedPathValue
this._tag,
this.malformedPathValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ public boolean isTemplateAttributeTooLarge() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
templateNotFoundValue
this._tag,
this.templateNotFoundValue
});
hash = (31 * super.hashCode()) + hash;
return hash;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ public List<PropertyGroup> getPropertyGroups() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
path,
propertyGroups
this.path,
this.propertyGroups
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ public TemplateFilter getTemplateFilter() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
queries,
templateFilter
this.queries,
this.templateFilter
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public String getCursor() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
cursor
this.cursor
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
propertyGroupLookupValue
this._tag,
this.propertyGroupLookupValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,10 +109,10 @@ public List<PropertyGroup> getPropertyGroups() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
id,
path,
isDeleted,
propertyGroups
this.id,
this.path,
this.isDeleted,
this.propertyGroups
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,8 +173,8 @@ public boolean isOther() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
_tag,
fieldNameValue
this._tag,
this.fieldNameValue
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ public LogicalOperator getLogicalOperator() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
query,
mode,
logicalOperator
this.query,
this.mode,
this.logicalOperator
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ public String getCursor() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
matches,
cursor
this.matches,
this.cursor
});
return hash;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ public String getValue() {
@Override
public int hashCode() {
int hash = Arrays.hashCode(new Object [] {
name,
value
this.name,
this.value
});
return hash;
}
Expand Down
Loading