Added _ca_certs property to _SSLAdapter to properly support pickling (broke in SDK v11.33) #440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Dropbox SDK v11.33 PR #385 added a new
_ca_certs
property to_SSLAdapter
.However, the property is dynamically specified, which breaks unpickling it using
pickle.loads()
:The fix is simple: Define the property instead of dynamically defining it.
Checklist
General Contributing
Is This a Code Change?
Non-code related change (markdown/git settings etc)Example/Test Code ChangeValidation
tox
pass?