Skip to content

Stop providing a hardcoded CA bundle #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 9, 2024
Merged

Stop providing a hardcoded CA bundle #489

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe0a4f4
remove trusted-certs, make `ca_certs` optional
maxbelanger May 6, 2024
4d07996
add fixture to test pinning
maxbelanger May 7, 2024
48049e8
add sanity check test for pinning when using expired certs
maxbelanger May 7, 2024
0b58be6
some documenting
maxbelanger May 7, 2024
3e39f8e
better comments
maxbelanger May 8, 2024
99c3cb0
lint
maxbelanger May 8, 2024
f236918
doc is slightly incorrect
maxbelanger May 8, 2024
8ff2ee5
wordsmithing
maxbelanger May 8, 2024
d5ee9c8
slightly better coverage of `ca_certs` param
maxbelanger May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@maxbelanger
maxbelanger committed May 8, 2024
commit 99c3cb08dab5026cdbcdc278544f389e300a9883
2 changes: 1 addition & 1 deletion test/integration/test_dropbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,5 +328,5 @@ def test_bad_auth(dbx_session):
def test_bad_pins():
# sanity-check: if we're pinning using expired pins, we should fail w/ an SSL error
_dbx = Dropbox("dummy_token", ca_certs=_EXPIRED_CERTS_FILE)
with pytest.raises(SSLError,) as cm:
with pytest.raises(SSLError,):
_dbx.files_list_folder('')