This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Breakage report improvements #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/breakage_report_improvements
… into fcappelli/breakage_report_improvements
# Conflicts: # Package.swift
federicocappelli
changed the title
10 tasks
tomasstrba
approved these changes
Nov 28, 2023
Contributor
tomasstrba
left a comment
tomasstrba
left a comment
There was a problem hiding this comment.
LGTM! ✅ Let me smoke test iOS and macOS apps
federicocappelli
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 6, 2023
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f Tech Design URL: https://app.asana.com/0/1205842942115003/1205917507991804/f **Description**: This PR introduces a new version of BSK (PR: duckduckgo/BrowserServicesKit#578) that allows iOS and macOS to share the same web implementation of the `ReportBrokenSite` page and introduce improvements to Pixels and the broken site report data. Additional changes - The old native `Report broken site` page has been removed - Added 2 new Pixels https://app.asana.com/0/1205842942115003/1205859726054342/f - Removed legacy PrivacyDashboard.storyboard localised strings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205692741026215/f
iOS PR: duckduckgo/iOS#2168
macOS PR: duckduckgo/macos-browser#1864
What kind of version bump will this require?: Major (Braking changes in privacy-dashboard)
Description:
The previous implementation of the
Report Broken Sitepage was different between iOS and macOS, with this PR I have updated and aligned the PrivacyDashboardController so the web implementation of theReport Broken Sitecan be used in both iOS and macOS.The changes are mostly around delegates and which User script is handled for each platform.
PrivacyDashboardNavigationDelegate,PrivacyDashboardReportBrokenSiteDelegate,PrivacyDashboardControllerDelegateSteps to test this PR:
macOS: try
Privacy Dashboardand the navigation to the webReport Broken Site, the functionality must remain the same.iOS:
Report Broken SitefromPrivacy Dashboardshows the web page and all the features are correctReport Broken Sitefrom the app menu shows the web page and all the features are correctOS Testing: