This repository was archived by the owner on Feb 24, 2025. It is now read-only.
MacOS lock autofill form filling #1962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
approved these changes
Aug 30, 2023
Contributor
ayoy
left a comment
ayoy
left a comment
There was a problem hiding this comment.
LGTM, but keep in mind that your branch doesn't compile because of some NetP code. Probably merging with develop will fix it.
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
afterxleep
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 1, 2023
Required: Task/Issue URL: https://app.asana.com/0/1142021229838617/1205368379915227/f iOS PR: duckduckgo/iOS#1962 macOS PR: duckduckgo/macos-browser#1559 What kind of version bump will this require?: Major Optional: Description: Allows users to lock form filling for usernames, passwords and credit cards when autofill is locked.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205344392346068/f
BSK PR: duckduckgo/BrowserServicesKit#482
Description:
macOS lock autofill for forms.
Steps to test this PR:
Internal references:
Software Engineering Expectations
Technical Design Template