This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Settings Sync Provider with support for syncing Email Protection #1963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205254652502303/f
Tech Design URL: https://app.asana.com/0/481882893211075/1205248329666560/f
Description:
Adding SyncSettingsAdapter to handle Sync for supported settings (currently only Email Protection auth status).
EmailManager notifications can now be posted from a background thread (by Sync) so their handlers
in the app were updated to run always on main thread (which is required because they update UI).
Sync is automatically triggered whenever Email Protection auth status change (unless the change was caused
by Sync itself).
Steps to test this PR:
Refer to BSK PR for testing steps.
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template