This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Integrates some of the latest BSK changes #1967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
samsymons
approved these changes
Sep 1, 2023
Contributor
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
LGTM, pending a fix for the unit test suite. Thanks!
Contributor
Author
|
Thank you for fixing this @samsymons ! |
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 3, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381133187308/f iOS PR: duckduckgo/iOS#1967 macOS PR: duckduckgo/macos-browser#1562 What kind of version bump will this require?: Minor ## Description Adds the waitlist remote flags. --------- * Add the Network Protection feature and waitlist subfeature. * Rename NetworkProtectionFeatureVisibility to NetworkProtectionFeatureActivation. * Hardcode NetP on. * Adds the waitlistBetaActive remote subfeature * Removes an override --------- Co-authored-by: Sam Symons <[email protected]>
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 3, 2023
Task/Issue URL: https://app.asana.com/0/0/1205381133187306/f ## Related PRs BSK PR: duckduckgo/BrowserServicesKit#483 iOS PR: duckduckgo/iOS#1967 ## Description Adds logic to handle the remote `waitlistBetaActive` subfeature, and to reset Network Protection once the beta is no longer active.
diegoreymendez
deleted the
diego/waitlist-beta-disable-feature-flag-2
branch
samsymons
added a commit
that referenced
this pull request
Sep 4, 2023
# By Diego Rey Mendez # Via GitHub * develop: Integrates some of the latest BSK changes (#1967) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205381133187310/f
Related PRs
BSK PR: duckduckgo/BrowserServicesKit#483
macOS PR: duckduckgo/macos-browser#1562
Description
Integrates some of the latest changes from BSK.
Tests:
Just ensure the CI tests succeed.
Internal references:
Software Engineering Expectations
Technical Design Template