This repository was archived by the owner on Feb 24, 2025. It is now read-only.
PacketTunnelProvider crash debug buttons #1978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205376937712482/f
Tech Design URL:
CC:
Description:
To verify that crash reporting works as expected from the PacketTunnelProvider extension, this PR adds debug menu items to trigger two types of crash: a fatal error and a memory overuse crash.
Note that this is an MVP of this functionality to verify that crash reports are sending. MacOS has a more elegant way of doing this realtime through sending messages, but I’ve kept this a bit simpler on iOS to start with.
Also note that iOS now has an implementation where simulation options are mutually exclusive. I’m aware this introduces a divergence between the two platforms, but thought I’d use this as somewhat of a proposal for how we could handle these as it’s a bit more concise code-wise and I believe it doesn’t really make sense to trigger multiple simulation options at the same time.
Steps to test this PR:
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template