Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@brindy
Copy link
Contributor

@brindy brindy commented Sep 6, 2023

Task/Issue URL: https://app.asana.com/0/414235014887631/1205185501564329/f
Tech Design URL:
CC:

Description:
Removes Lock Screen widget pixels.

Steps to test this PR:

  1. Run the app.
  2. Add some Lock Screen widgets
  3. Use them, check no pixels are sent related to their usage

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy requested review from a team and miasma13 and removed request for a team September 6, 2023 12:36
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@brindy brindy merged commit bb92e7d into develop Sep 7, 2023
@brindy brindy deleted the brindy/remove-lock-screen-pixels branch September 7, 2023 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants