Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@graeme
Copy link
Contributor

@graeme graeme commented Sep 7, 2023

Task/Issue URL: https://app.asana.com/0/0/1205437127875013/f

Description:
The iOS VPN has been disconnecting in the background. We have some suspicions this could be due to CPU / energy usage or excessive wake-ups. The only thing that jumped out while profiling was the NetworkProtectionConnectionTester so I’m going to try disabling this to see if it has any impact.

Steps to test this PR:

  1. Just check Network Protection works by following smoke test steps https://app.asana.com/0/0/1205201898139906/f

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme merged commit f2962f8 into develop Sep 7, 2023
@graeme graeme deleted the graeme/try-disabling-connection-tester branch September 7, 2023 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants