Optimizing the logins list screen

[amddg44]

Task/Issue URL: https://app.asana.com/0/1201493110486074/1205258271017091/f
Tech Design URL:
CC:

Description:
Removes unused legacy favicon code that was impacting screen loading times

Steps to test this PR:

1. Set up a very large dataset (minimum 1500) of logins for testing
2. On existing develop branch code, run up the app and attempt to access the Logins screen. Note the long pause between tapping on Logins and the screen actually segueing & loading
3. Run up this PR and repeat step 2. The delay should be significantly reduced
4. Smoke test favicons lightly by opening in tabs the sites for some of the Logins that have a placeholder favicon
5. Go back to the Logins screen and confirm the favicons have been updated from placeholders to actual site favicons

Copy Testing:

• Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

• Portrait
• Landscape

Device Testing:

• iPhone SE (1st Gen)
• iPhone 8
• iPhone X
• iPhone 14 Pro
• iPad

OS Testing:

• iOS 14
• iOS 15
• iOS 16

Theme Testing:

• Light theme
• Dark theme

---

Internal references:

Software Engineering Expectations
Technical Design Template

[bwaresiak]

Great job!