Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 7, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205255888342957/f
Tech Design URL:
CC:

Description:
Prevent autofill from autoprompting saved long in preview tabs i.e. when long pressing on a link

Steps to test this PR:

  1. Save a login for https://fill.dev/
  2. Visit https://fill.dev/ and tab the hamburger menu, then the Login menu option
  3. Long press on the link Simple and when the link preview appears confirm that you are not prompted to use your saved login
  4. Open the link in new tab and confirm the login prompt works as normal
  5. Repeat step 3 but this time chose to open the tab in background
  6. Visit the newly opened tab and confirm there is no change in behaviour (no autoprompt but tapping on key icon brings up the autofill prompt of saved logins)

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep self-requested a review September 8, 2023 14:37
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: No prompt shown..

Screenshot 2023-09-08 at 4 38 27 PM

@amddg44 amddg44 merged commit f0990af into develop Sep 11, 2023
@amddg44 amddg44 deleted the anya/autofill-prevent-preview-prompts branch September 11, 2023 13:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants