Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Conversation

@samsymons
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/414235014887631/1205185500420499/f
Tech Design URL:
CC: @brindy

Description:

This PR fixes the iOS 17 widget view.

We're one beta away from GM, so I view it as unlikely that anything will improve here - to make sure we're safe, I've swapped over to a Circle view from Rectangle.

See attached screenshots below for iOS 16 and 17 screenshots.


iOS 16:

Lock Screen Widgets - iOS 16

iOS 17:

Lock Screen Widgets - iOS 17

Steps to test this PR:

  1. Run the app on an iOS 16 device and make sure the widget view looks good
  2. Run the app on an iOS 17 device and make sure the widget view looks good (simulator should be fine here)

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from brindy September 10, 2023 20:41
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @samsymons

@samsymons samsymons merged commit 0c93248 into develop Sep 11, 2023
@samsymons samsymons deleted the sam/fix-ios-17-lock-screen-widgets branch September 11, 2023 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants