This repository was archived by the owner on Feb 24, 2025. It is now read-only.
NetP Geoswitching Design Review feedback #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Nov 29, 2023
Contributor
samsymons
left a comment
samsymons
left a comment
There was a problem hiding this comment.
Copy change looks good
samsymons
added a commit
that referenced
this pull request
Nov 30, 2023
# By Dominik Kapusta (1) and others # Via GitHub * develop: moving the toggle to the top of the dashboard (#2166) Allow automated fetching of synced bookmarks' favicons (#2163) NetP Geoswitching Design Review feedback (#2206) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Dec 5, 2023
* develop: (40 commits) Address Bar Spoofing Tests + Remediation (#2181) Update Sync e2e tests to fit the new UI (#2215) NetP waitlist final touches (#2209) NetP: Remove port from server address (#2214) NetP: Fix list row colours (#2213) Reset VPN waitlist T&C (#2212) Report macOS active/new user for netP (#2207) Sabrina/sync setup update (#2198) new pixels for toolbars and share sheet (#2208) Use design system fonts throughout NetP (#2211) moving the toggle to the top of the dashboard (#2166) Allow automated fetching of synced bookmarks' favicons (#2163) NetP Geoswitching Design Review feedback (#2206) update theme to use system colours (#2180) Release 7.99.0 (#2205) Update iOS privacy defaults (#2185) Remove disabled switches from VPN Settings screen (#2203) Update BSK for VPN settings (#2165) Fix migrating from Bookmarks V2 and older (#2196) Autofill pixel parameter removed (#2182) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206040993247659/f
Description:
Just requires an addition of a period at the end of a footer string + an updated design for the Preferred Location item on Settings as per designs (see task).
Steps to test this PR:
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template