-
-
Notifications
You must be signed in to change notification settings - Fork 835
HTTP/2 and HTTPS support #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dockerfile
Outdated
|
||
WORKDIR /srv/app | ||
RUN php -r "copy('$SKELETON_COMPOSER_JSON', 'composer.json');" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could use ADD
here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because the file is not included in the repo. But I’ll switch to composer create-project in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? ADD
works with remote urls...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of that! great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I was pretty happy too when I realised I didn't actually need curl or wget :) or php -r
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but from what I remember ADD cannot be cached as a layer by docker so it's quite a pain when you are rebuilding your image a lot. Perhaps it is not the case anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I've found a better way (no more copy
nor ADD
).
Dockerfile.h2-proxy
Outdated
-signkey /usr/local/apache2/conf/server.key \ | ||
-out /usr/local/apache2/conf/server.crt | ||
|
||
COPY ./docker/httpd/httpd.conf /usr/local/apache2/conf/httpd.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could maybe use here a multi stage build, first stage will create the certificate, second step will only copy them to apache so no need to have openssl as a dependency (unless it's required for apache to do https ?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing so would allow you do avoid all these &&
because you wouldn't care about having many layers anymore. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent idea @joelwurtz. It's done.
f506e0f
to
019748f
Compare
HTTP/2 and HTTPS support
Just open
https://localhost
.