Skip to content

Update skeleton.css #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Update skeleton.css #133

merged 1 commit into from
Feb 8, 2022

Conversation

zignis
Copy link
Contributor

@zignis zignis commented Feb 4, 2022

Solves the unwanted misplacement of skeleton child (used to have a gap at the top in rare cases).

@srmagura
Copy link
Collaborator

srmagura commented Feb 4, 2022

Hey @hexm7, would you be able to provide a CodeSandbox that shows the problem this PR solves?

@zignis
Copy link
Contributor Author

zignis commented Feb 5, 2022

Here is the demo: https://codesandbox.io/s/serverless-darkness-2ipti?file=/src/App.js
Everything is fine on the initial render, but as you change something in the CSS file you'll notice the animated element getting shifted a bit. I have attached a screenshot.

serverless-darkness-2ipti - CodeSandbox - Google Chrome 2_5_2022 4_39_08 PM

@srmagura
Copy link
Collaborator

srmagura commented Feb 6, 2022

I'm just seeing the default React template when I visit that link. Did you send the correct link?

image

@zignis
Copy link
Contributor Author

zignis commented Feb 7, 2022

I'm extremely sorry as I'm new to CodeSandBox. Here's the StackBlitz project: https://stackblitz.com/edit/react-vqvafn?file=src%2FApp.js

@srmagura srmagura merged commit 6fb13f9 into dvtng:master Feb 8, 2022
@srmagura
Copy link
Collaborator

srmagura commented Feb 8, 2022

Thanks @hexm7! I don't understand why top: 0 is required in this case, but it shouldn't have any negative side effects. I will work on getting this ready for release.

srmagura added a commit that referenced this pull request Feb 8, 2022
srmagura added a commit that referenced this pull request Feb 8, 2022
* Add story for PR #133

* Update changelog for 3.0.3

* Typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants