kpatch-build: fix gcc_version_check: both "GNU" and "GCC" are possible #561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is an addition to 9fedd0d "kpatch-build: fix gcc_version_check". On some systems, the GCC version stored in vmlinux may have the following format: (GNU) 4.8.3 20140911 (Red Hat 4.8.3-9) while GCC returns (GCC) 4.8.3 20140911 (Red Hat 4.8.3-9) As a result, binary patches cannot be built, although the compiler is the same. gcc_version_check() now takes this into account. Signed-off-by: Evgenii Shatokhin <[email protected]>
Member
|
👍 |
Member
|
@Spartacus06 Merging this one now because it fixes a regression (kpatch-build always reports a gcc mismatch). |
jpoimboe
added a commit
that referenced
this pull request
Nov 18, 2015
kpatch-build: fix gcc_version_check: both "GNU" and "GCC" are possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is an addition to 9fedd0d "kpatch-build: fix
gcc_version_check".
On some systems, the GCC version stored in vmlinux may have the
following format:
(GNU) 4.8.3 20140911 (Red Hat 4.8.3-9)
while GCC returns
(GCC) 4.8.3 20140911 (Red Hat 4.8.3-9)
As a result, binary patches cannot be built, although the compiler is
the same.
gcc_version_check() now takes this into account.
Signed-off-by: Evgenii Shatokhin [email protected]