decorator does not work

[fxdgear]

Using class based views I get the following error:

'MyPostDetailView' object has no attribute 'scheme'

http://dpaste.com/0KNM2VJ

[daneah]

@fxdgear thanks for filing this issue! I'm surprised at the error, because the method is expecting an HttpRequest object but is receiving a view object. This isn't an issue I've run into yet, so my initial suspicion is a version/configuration mismatch. Can you please provide the Django version you're using, and whether you're using the MIDDLEWARE setting or the MIDDLEWARE_CLASSES setting? If you have time, an example of the code where you're using the decorator would be helpful as well!

[fxdgear]

My versions are included in the dpaste.

It might be a version mismatch, but I ended up forking your project and vendoring it into my site.

Once I get complete I will try to submit a PR back.

I’ve added a fair bit of functionality and expanded on what you’ve done.

Thanks for making this project

[daneah]

Hmm, I didn't see the versions in the dpaste when I looked, and it's now expired. Sorry about that! I appreciate your time, I'm happy to incorporate a PR!

[fxdgear]

Ahh shoot.

…

On Tue, Jan 1, 2019 at 07:08 Dane Hillard ***@***.***> wrote: Hmm, I didn't see the versions in the dpaste when I looked, and it's now expired. Sorry about that! I appreciate your time, I'm happy to incorporate a PR! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAI8dq4oNvxUtQUUvT0KjN9da-2QEo4Qks5u-2vvgaJpZM4ZlKI6> .

[fxdgear]

Django 2.1 python 3.7 On Tue, Jan 1, 2019 at 07:20 [email protected] <[email protected]> wrote:

…

Ahh shoot. On Tue, Jan 1, 2019 at 07:08 Dane Hillard ***@***.***> wrote: > Hmm, I didn't see the versions in the dpaste when I looked, and it's now > expired. Sorry about that! I appreciate your time, I'm happy to incorporate > a PR! > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#6 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAI8dq4oNvxUtQUUvT0KjN9da-2QEo4Qks5u-2vvgaJpZM4ZlKI6> > . >

[oma0256]

@daneah @fxdgear I was this issue resolved?

[daneah]

@oma0256 I haven't been able to explore this any further since then. If you're able to provide details about your use case and the issue you're seeing (if anything differs from above), it would be helpful to me! I'm happy to try to get another release out soon if I can.

[oma0256]

@daneah I actually wanted to explore options of raising a PR to fix this, if it is still an issue.

[daneah]

@oma0256 submissions definitely welcome! If you need any help or have questions, please let me know. Otherwise, I look forward to your pull request 😄

[philgyford]

It's been a while, but I've just tried the app and found the same problem (python 3.8, Django 3.1).

Either decorating the dispatch method:

class PostDetailView(DateDetailView):

    @method_decorator(include_webmention_information)
    def dispatch(self, *args, **kwargs):
        return super().dispatch(*args, **kwargs)

or the class:

@method_decorator(include_webmention_information, name="dispatch")
class PostDetailView(DateDetailView):

I get:

  File "/Users/phil/Projects/personal/django-hines/hines/weblogs/urls.py", line 4, in <module>
    from . import feeds, views
  File "/Users/phil/Projects/personal/django-hines/hines/weblogs/views.py", line 122, in <module>
    class PostDetailView(TemplateSetMixin, DateDetailView):
  File "/Users/phil/Projects/personal/django-hines/hines/weblogs/views.py", line 145, in PostDetailView
    def dispatch(self, *args, **kwargs):
  File "/Users/phil/.local/share/virtualenvs/django-hines-jsiYO4hw/lib/python3.8/site-packages/django/utils/decorators.py", line 63, in _dec
    return _multi_decorate(decorator, obj)
  File "/Users/phil/.local/share/virtualenvs/django-hines-jsiYO4hw/lib/python3.8/site-packages/django/utils/decorators.py", line 47, in _multi_decorate
    _update_method_wrapper(_wrapper, dec)
  File "/Users/phil/.local/share/virtualenvs/django-hines-jsiYO4hw/lib/python3.8/site-packages/django/utils/decorators.py", line 17, in _update_method_wrapper
    def dummy(*args, **kwargs):
  File "/Users/phil/.local/share/virtualenvs/django-hines-jsiYO4hw/lib/python3.8/site-packages/django/utils/decorators.py", line 117, in _decorator
    middleware = middleware_class(view_func, *m_args, **m_kwargs)
TypeError: WebMentionMiddleware() takes no arguments

Googling, I guess WebMentionMiddleware() needs to be updated to include __init__() and __call__() methods as in the instructions? Looks like that was changed in Django 1.10.

[daneah]

@philgyford thanks for the details! An alternative for backward compatibility would be to use the MiddlewareMixin—hard to say how many are still using the old-style middleware.

I should be able to get to this today unless you're interested in taking a stab at it.

[philgyford]

Sure - I'm stabbing at it right now :)

[daneah]

@philgyford oh, afraid I may have misled you! There already exist an old and a new version of the middleware—the problem being that the decorator uses the old one.

I could see adding a second decorator that uses the new middleware, but suggestions also welcome.

[philgyford]

Ah, right. I'm not sure then. A second decorator maybe makes sense then? TBH I've never written decorators or middleware so anything beyond adding that mixin is probably going to take me a lot longer than someone with more experience, if you have time. Sorry!

[daneah]

No worries, I’ll have a look 😄

[daneah]

This should now be fixed in django-webmention==2.0.0

[philgyford]

Great, many thanks @daneah!