-
Notifications
You must be signed in to change notification settings - Fork 10
Django 4.0 Compatibility #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 4.0 Compatibility #25
Conversation
Because django.conf.urls.url was removed in Django 4.0.
As it's now required and will throw an error if not provided.
setup.cfg
Outdated
@@ -16,6 +16,9 @@ classifiers = | |||
Framework :: Django :: 2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it wouldn't be worthwhile to remove support for older, unsupported versions of Django?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jamesvandyne! Django 3.2 and Python 3.7 are now the lowest supported versions, so I recommend we drop support for earlier versions in this same change set as well.
Additional notes:
|
@daneah I've dropped support for unsupported versions of Django in the setup.cfg and tweaked the readme. If you think the readme needs further tweaking, please feel free to commit to this branch / PR any changes. |
I will try to get a release of this out shortly; this project doesn't currently follow my usual flow so I'll need to do a little archaeology. I'll hopefully be able to follow up on adhering to that flow soon after. |
This PR updates django-webmention to work with Django 4.0 or higher. It does this by:
re_path
instead of the removeddjango.conf.urls.url
.get_response
value to the the middleware test fixture.In addition, I've also updated the setup.cfg to test/notate compatibility with Python 3.9 - 3.11 and Django 3.2 - 4.1.