Skip to content

Fix missed message in trivial equal-asserts #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

Flamefire
Copy link
Contributor

The default error is raised for trivial types but the message was not passed along and is missing in that case.

Co-authored-by: ocaisa <[email protected]>
ocaisa
ocaisa previously approved these changes Apr 1, 2025
@Flamefire
Copy link
Contributor Author

Looks like there was an update to flake8 or previously missed check. Fixed

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa ocaisa merged commit bdc066d into easybuilders:develop Apr 2, 2025
37 checks passed
@Flamefire Flamefire deleted the fix-assert branch April 2, 2025 08:26
@boegel boegel added the bug fix label Apr 2, 2025
@boegel boegel added this to the release after 5.0.0 milestone Apr 2, 2025
@boegel boegel added the tests label Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants