Dynamic length messages #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor RDBI handling to support MIN-MAX-LENGTH-TYPE - (re)write RDBI unit tests with pytest
Pog3k
reviewed
Nov 22, 2022
Pog3k
reviewed
Nov 22, 2022
Pog3k
reviewed
Nov 22, 2022
uds/uds_config_tool/FunctionCreation/ReadDataByIdentifierMethodFactory.py
Outdated
Show resolved
Hide resolved
Pog3k
reviewed
Nov 22, 2022
Pog3k
reviewed
Nov 22, 2022
cody82
reviewed
Nov 22, 2022
- improve docstring in UtilityFunctions findDescendant() - remove leftover TODO in UtilityFunctions - add type hint for _getTermination() argument - remove unnecessary typehint in RDBIFactory - fix typo in Uds.load_odx() docstring
Pog3k
approved these changes
Nov 23, 2022
sebclrsn
requested changes
Nov 25, 2022
uds/uds_config_tool/FunctionCreation/ReadDataByIdentifierMethodFactory.py
Outdated
Show resolved
Hide resolved
uds/uds_config_tool/FunctionCreation/ReadDataByIdentifierMethodFactory.py
Outdated
Show resolved
Hide resolved
uds/uds_config_tool/SupportedServices/ReadDataByIdentifierContainer.py
Outdated
Show resolved
Hide resolved
- run black and fix imports - change to pep8 compliant naming of variables and functions/ methods - fixed test dependencies in setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor RDBIMethodFactory and RDBIContainer so it can handle STaNDARD-LENGTH-TYPE and MIN-MAX-LENGTH-TYPE messages
fix unit tests for RDBI functions and move them to pytest