Fix issue when uds message is longer than 62 bytes #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebclrsn
requested changes
Nov 28, 2022
Pog3k
reviewed
Nov 28, 2022
| ), | ||
| 64, | ||
| ) | ||
| - 1 |
There was a problem hiding this comment.
- 1 for one PCI byte ? In a first frame PCI could be 2 bytes long..
Please check, not deep enough in those topic.
Also the lack of unittests scares me
Pog3k
approved these changes
Dec 5, 2022
sebclrsn
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue happens when you use the function
send_uds_rawfrom UdsAuxiliary of kiso-testing with the following code :And the messages send were :
Instead of sending a message of 8 bytes for the last 4 bytes of data it send a message 64 bytes long