Skip to content

Feat/add response timing #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 28, 2023
Merged

Feat/add response timing #15

merged 4 commits into from
Aug 28, 2023

Conversation

TedRio
Copy link
Contributor

@TedRio TedRio commented Aug 16, 2023

No description provided.

sebclrsn
sebclrsn reviewed Aug 17, 2023
View reviewed changes
sebclrsn
sebclrsn reviewed Aug 17, 2023
View reviewed changes
sebclrsn
sebclrsn reviewed Aug 17, 2023
View reviewed changes
sebclrsn
sebclrsn reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@sebclrsn sebclrsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This provides the minimal required functionality but opens the doors to more improvements, tbd whether it should be tackled in a separate PR

@sebclrsn sebclrsn self-requested a review August 17, 2023 14:56
sebclrsn
sebclrsn reviewed Aug 17, 2023
View reviewed changes
@TedRio @sebclrsn
chore: fix typo
bbaa23a 
Co-authored-by: Sebastian Clerson <[email protected]>
@Pog3k Pog3k merged commit 2d8d5dc into eclipse-kiso-testing:master Aug 28, 2023
@sebastianpfischer
Copy link

@Pog3k , @sebclrsn , pleas make sure the CHANGELOG is not manually updated next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pog3k Pog3k Pog3k approved these changes

@sebclrsn sebclrsn sebclrsn approved these changes

@sebastianpfischer sebastianpfischer Awaiting requested review from sebastianpfischer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TedRio @sebastianpfischer @Pog3k @sebclrsn