Skip to content

Conversation

JonKoser
Copy link
Contributor

@JonKoser JonKoser commented Oct 2, 2019

This PR updates the code to Python3 and fixes the retina display issues for OSX.

I haven't written issues for these so if you'd like me to do that first, please let me know.

@JonKoser
Copy link
Contributor Author

JonKoser commented Oct 2, 2019

Oh yeah, Tkinter -> tkinter.
Maybe this should be a brand-new repo...

JonKoser and others added 2 commits October 2, 2019 17:41
@matejc matejc force-pushed the feature/python3 branch 2 times, most recently from 1c26f70 to c62897c Compare April 8, 2020 11:03
@matejc
Copy link

matejc commented Apr 8, 2020

@JonKoser Hey, thank you for this pull request. I have reviewed it, it works as expected on python 3.x. Do you have any unfinished work before we merge this into master?

@JonKoser
Copy link
Contributor Author

JonKoser commented Apr 8, 2020

I have another branch which adds a confidence level for OpenCV image recognition, but I can set that up as a separate PR. Thanks for looking over this!

@JonKoser
Copy link
Contributor Author

JonKoser commented Apr 8, 2020

Alternatively, I could merge it to this. Which do you prefer?

@JonKoser JonKoser marked this pull request as ready for review April 8, 2020 13:05
@matejc
Copy link

matejc commented Apr 8, 2020

I have been looking into OpenCV's confidence level also, but if you had done it already - perfect! But yes, that's for another pull request!

@matejc matejc force-pushed the feature/python3 branch from c62897c to a4a8ce5 Compare April 8, 2020 14:28
@matejc matejc merged commit 4dd71eb into eficode:master Apr 8, 2020
@JonKoser JonKoser deleted the feature/python3 branch April 11, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants