Skip to content

Conversation

v1v
Copy link
Member

@v1v v1v commented Apr 26, 2024

What

If a github release exists, then it fails. Avoid rerunning the workflow since AWS lambdas are immutable and their versions are bumped if created a new one.

Why

This should avoid the edge case that a GitHub workflow was triggered accidentally and remove the lambdas.

Test

image

Further details

github.ref_name string The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, feature-branch-1.
For pull requests, the format is <pr_number>/merge.

@v1v v1v requested review from a team April 26, 2024 12:16
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Apr 26, 2024
dmathieu
dmathieu previously approved these changes Apr 26, 2024
@reakaleek
Copy link
Member

@dmathieu dmathieu self-requested a review April 26, 2024 12:18
@dmathieu
Copy link
Member

Won't the tag always already exist, since this action is triggered by its creation?

reakaleek
reakaleek previously approved these changes Apr 26, 2024
kruskall
kruskall previously approved these changes Apr 26, 2024
@v1v
Copy link
Member Author

v1v commented Apr 26, 2024

Won't the tag always already exist, since this action is triggered by its creation?

😄 ... did I took the wrong approach here?

I'll use the release validation instead

@v1v v1v dismissed stale reviews from kruskall, reakaleek, and dmathieu via b6b5a56 April 26, 2024 12:32
@v1v v1v requested review from kruskall and reakaleek April 26, 2024 12:32
@v1v v1v changed the title github-action: avoid release if tag already exists github-action: avoid release if github release already exists Apr 26, 2024
@v1v v1v enabled auto-merge (squash) April 26, 2024 12:50
@v1v v1v merged commit b9fba8d into main Apr 26, 2024
@v1v v1v deleted the avoid-release-if-tag-exists branch April 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants