Skip to content

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Oct 19, 2021

Part of #56.

This PR adds a feature document for the Lambda Extension. The intent of this document is to give an overview of the Lambda extension, and then provide end users with instructions on how they can install the extension using either the Node.js based installed, or manually take a release and install it.

The current audience for this document is our early access users.

All Feedback is welcome, but specifically

  • Is there additional information we need to pass on to our early access users?
  • Post-early access, what's additional information might be needed for this doc?
  • All.The.Type.Os

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Oct 19, 2021
@ghost
Copy link

ghost commented Oct 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-27T21:40:38.577+0000

  • Duration: 6 min 21 sec

  • Commit: a8fbb5f

Test stats 🧪

Test Results
Failed 0
Passed 66
Skipped 0
Total 66

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@bmorelli25
Copy link
Member

Pushed a few quick asciidoc changes as I wanted to get them in before others start reviewing. I'll leave a content review tomorrow.

@astorm
Copy link
Contributor Author

astorm commented Oct 27, 2021

Thanks all for your feedback. I've either incorporated your changes, or opened new issues to address bigger changes once we've gotten the early access version out the door. I've also added a section on how a user could manually install this extension.

Next steps for this doc

  1. Are there any additional changes we want to do before our first week of november early access release? If not, let's get this merged. (i.e. the review request)

  2. Once merged we'll have a few more things to work on.

@astorm astorm marked this pull request as ready for review October 27, 2021 21:50
@AlexanderWert AlexanderWert self-requested a review November 3, 2021 09:28
Copy link
Member

@AlexanderWert AlexanderWert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astorm astorm merged commit d16b80d into main Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-03T19:41:34.415+0000

  • Duration: 8 min 32 sec

  • Commit: fee9e0d

Test stats 🧪

Test Results
Failed 0
Passed 66
Skipped 0
Total 66

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@felixbarny
Copy link
Member

I missed this earlier but we might want to move the apm-lambda-extension/docs folder to the top level?

@astorm astorm deleted the astorm/docs branch November 15, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension AWS Lambda Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants