accumulator: add error handling for writing to buffer #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

florianl merged 4 commits into main from florianl-patch-1

Oct 21, 2024

Member

florianl commented Oct 21, 2024

Errors were ignored so far when trying to write to the buffer.


          accumulator: add error handling for writing to buffer

a63cf1b

Errors were ignored so far when trying to write to the buffer.

github-actions bot added the aws-λ-extension label

florianl commented

View reviewed changes

accumulator/batch.go Outdated Show resolved Hide resolved


          Update accumulator/batch.go

d94590f

rockdaboot reviewed

View reviewed changes

accumulator/batch.go Show resolved Hide resolved

rockdaboot reviewed

View reviewed changes

accumulator/batch.go Outdated Show resolved Hide resolved

florianl commented

View reviewed changes

accumulator/batch.go Outdated Show resolved Hide resolved

florianl commented

View reviewed changes

accumulator/batch.go Outdated Show resolved Hide resolved


          Apply suggestions from code review

c0daf14

florianl commented

View reviewed changes

accumulator/batch.go Outdated Show resolved Hide resolved


          Apply suggestions from code review

7ca58dd

rockdaboot approved these changes

View reviewed changes

Contributor

rockdaboot left a comment

LGTM

(nit: merge err != nil into previous line)

florianl merged commit e6317e4 into main

8 checks passed

florianl deleted the florianl-patch-1 branch

October 21, 2024 15:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws-λ-extension