Return an error if the logs API is not supported when attempting to subscribe to it #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
astorm
approved these changes
Oct 25, 2021
|
|
||
| if resp.StatusCode == http.StatusAccepted { | ||
| log.Println("Logs API is not supported. Is this extension running in a local sandbox?") | ||
| return nil, errors.Errorf("Logs API is not supported in this environment") |
There was a problem hiding this comment.
👍 I'd missed this in the previous PRs, but it surprised me that a 202 response code means "we see you but this request won't do anything", but it's documented right here: https://docs.aws.amazon.com/lambda/latest/dg/runtimes-logs-api.html
Considering this an error case makes sense and is appropriate.
There was a problem hiding this comment.
The code was from the aws examples so I missed checking it closely...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we should return an error if the logs API is not supported instead of continuing the
subscribefunction.