Simpler calculation of time to wait until func deadline and timer creation #66
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
| axis { | ||
| name 'GO_VERSION' | ||
| values '1.14', '1.15', '1.16' | ||
| values '1.15', '1.16', '1.17' |
There was a problem hiding this comment.
Re: bumping the go versions -- since the extension is compiled down to machine code it should run in Amazon's Linux environments regardless of which version we use to compile it. So I don't see any issues in dropping support for 1.14 from our perspective.
The one possible negative tradeoff here is if a user's compiling their own extension and if that user doesn't have easy access to go 1.15 or greater, we'd might be leaving them behind if we start using go 1.15+ features.
There was a problem hiding this comment.
In a slack convo we decided we'll address older version support if the need comes up later on.
| // Create a timer that expires after timeToWait | ||
| timer := time.NewTimer(timeToWait) | ||
| // Create a timer that expires after durationUntilFlushDeadline | ||
| timer := time.NewTimer(durationUntilFlushDeadline) |
There was a problem hiding this comment.
+1 User of Time.Until is definitely clearer.
2 participants
Simplify how we calculate the deadline for flushing data before the function times out.
resolves #65