Comment specific preview links for changed files #1341
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately starting with a comment and updating when the deployment completes seems to need perms beyond the general GITHUB_TOKEN. I'm going to remove this functionality for now: 
|
…content into bmorelli25-patch-2
bmorelli25
changed the title
Mpdreamz
reviewed
May 2, 2025
| "", | ||
| ...links, | ||
| "", | ||
| "🔔 *The preview site may take up to **5 minutes** to finish building. These links will become live once it completes.*" |
There was a problem hiding this comment.
5 minutes? 😢 https://github.com/elastic/docs-content/actions/workflows/docs-build.yml begs to differ!
Its a safe margin I get it 😄
There was a problem hiding this comment.
Just spotted the attempts to update on deployment created ❤️ that!
I think adding these permissions to the workflow would be sufficient.
permissions:
deployments: read
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#permissions
There was a problem hiding this comment.
oh snap! Thanks, I'll give this a try
Mpdreamz
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comment with links from each changed file to the built location in the deployment preview. This comment will be updated every time a new commit is pushed.